ofri masad has posted comments on this change.

Change subject: webadmin: Added the quota to the Pool-general subtab
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java
Line 480:                     
poolGeneralModel.setTimeZone(getvm().getTimeZone());
Line 481: 
Line 482:                     
poolGeneralModel.setIsStateless(getvm().isStateless());
Line 483: 
Line 484:                     
poolGeneralModel.setQuotaName(getvm().getQuotaName());
vm != null see line 452
quotaName can be null - no problem with this.
Line 485: 
Line 486:                     
poolGeneralModel.setHasDefaultHost(getvm().getDedicatedVmForVds() != null);
Line 487:                     if (poolGeneralModel.getHasDefaultHost())
Line 488:                     {


Line 596:                 new GetAllDisksByVmIdParameters(getvm().getId()),
Line 597:                 _asyncQuery);
Line 598:     }
Line 599: 
Line 600:     private String quotaName;
Done
Line 601: 
Line 602:     public void setQuotaName(String quotaName) {
Line 603:         this.quotaName = quotaName;
Line 604:     }


Line 602:     public void setQuotaName(String quotaName) {
Line 603:         this.quotaName = quotaName;
Line 604:     }
Line 605: 
Line 606:     public String getQuotaName() {
the form is using it. it calls it by reflection
Line 607:         return quotaName;
Line 608:     }


-- 
To view, visit http://gerrit.ovirt.org/15283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib442572880ef75929eecfc19037cca4ad86f206b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to