Oved Ourfali has posted comments on this change.

Change subject: Support SSL providers
......................................................................


Patch Set 9: (3 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
Line 208:             return;
Line 209:         }
Line 210: 
Line 211:         flush();
Line 212:         Frontend.RunAction(action, new ProviderParameters(provider), 
null, true);
You're right. Will remove that.
Line 213:         cancel();
Line 214:     }
Line 215: 
Line 216:     private void onTest() {


Line 223:             @Override
Line 224:             public void executed(FrontendActionAsyncResult result) {
Line 225:                 VdcReturnValueBase res = result.getReturnValue();
Line 226:                 // If the connection failed on SSL issues, we try to 
fetch the provider certificate chain, and import it to the engine
Line 227:                 if (res != null && !res.getSucceeded() && 
res.getFault().getError().equals(VdcBllErrors.PROVIDER_SSL_FAILURE)) {
will do.
Line 228:                     AsyncQuery getCertChainQuery = new AsyncQuery();
Line 229:                     getCertChainQuery.asyncCallback = new 
INewAsyncCallback() {
Line 230:                         @Override
Line 231:                         public void onSuccess(Object model, Object 
result)


Line 234:                                 ConfirmationModel confirmationModel = 
getImportChainConfirmationModel((String) result);
Line 235:                                 
sourceListModel.setConfirmWindow(confirmationModel);
Line 236:                             } else {
Line 237:                                 stopProgress();
Line 238:                                 
setTestResultValue((VdcQueryReturnValue) result);
Discussed that with Lior, and we agreed that in case he cancels we don't 
continue with the connectivity testing.
Line 239:                             }
Line 240:                         }
Line 241:                     };
Line 242:                     
AsyncDataProvider.GetProviderCertificateChain(getCertChainQuery, provider);


-- 
To view, visit http://gerrit.ovirt.org/15128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35343409d74a4f90aae726b46781f27ce08a981a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to