Michael Pasternak has posted comments on this change.
Change subject: restapi : Update of power management via cli ignored(#959879)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 330: }
Line 331: VdsStatic updated = getMapper(modelType,
VdsStatic.class).map(incoming,
Line 332: entity.getStaticData());
Line 333: if (incoming.isSetPowerManagement()) {
Line 334: updated.setManagementIp(managementIp);
this should happen in the host mapper
Line 335: }
Line 336: UpdateVdsActionParameters updateParams = new
UpdateVdsActionParameters(updated, "", false);
Line 337: if (incoming.isSetOverrideIptables()) {
Line 338:
updateParams.setOverrideFirewall(incoming.isOverrideIptables());
Line 350: * @param model
Line 351: * @param vdsStatic
Line 352: * @return
Line 353: */
Line 354: private String getManagementIp(PowerManagement model, VdsStatic
vdsStatic) {
this method should be a part of the host mapper
Line 355: String newIp = vdsStatic.getManagementIp();
Line 356: if (model.getAddress() != null &&
!model.getAddress().equals(vdsStatic.getManagementIp())) {
Line 357: return model.getAddress();
Line 358: }
Line 352: * @return
Line 353: */
Line 354: private String getManagementIp(PowerManagement model, VdsStatic
vdsStatic) {
Line 355: String newIp = vdsStatic.getManagementIp();
Line 356: if (model.getAddress() != null &&
!model.getAddress().equals(vdsStatic.getManagementIp())) {
isSetAddress()
Line 357: return model.getAddress();
Line 358: }
Line 359: if (model.isSetAgents()) {
Line 360: for (Agent agent : model.getAgents().getAgents()) {
--
To view, visit http://gerrit.ovirt.org/14994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f2f425703cca688abf1ac3736a37ec5e3216840
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
