Daniel Erez has uploaded a new change for review.
Change subject: webadmin: fix Configure dialog styles
......................................................................
webadmin: fix Configure dialog styles
Adjusting Configure dialog widgets' styles
to accommodate dialog's dimensions.
Change-Id: I872e1b656dac03c146a806bdaf7fdcee4ef6fd26
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
4 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/15473/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
index 4d2dcbf..48d51a5 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
@@ -53,9 +53,9 @@
super(eventBus, resources);
initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
localize(constants);
- roleView.setWidth("95%"); //$NON-NLS-1$
+ roleView.setWidth("100%"); //$NON-NLS-1$
rolesTabPanel.add(roleView);
- systemPermissionTabPanel.setWidth("95%"); //$NON-NLS-1$
+ systemPermissionTabPanel.setWidth("100%"); //$NON-NLS-1$
systemPermissionTabPanel.add(systemPermissionView);
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
index 4225bb0..f2003df 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
@@ -3,26 +3,30 @@
<ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui"
xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab">
+ <ui:style>
+ .panel {
+ padding: 2px;
+ }
+ </ui:style>
+
<d:SimpleDialogPanel height="600px" width="1000px">
<d:header>
<g:Label ui:field="titleLabel" />
</d:header>
<d:content>
- <t:DialogTabPanel height="450px" width="900px">
+ <t:DialogTabPanel height="100%" width="100%">
<t:tab>
<t:DialogTab ui:field="rolesTab">
<t:content>
- <g:SimplePanel
width="750px" ui:field="rolesTabPanel" />
+ <g:SimplePanel
addStyleNames="{style.panel}" ui:field="rolesTabPanel" />
</t:content>
</t:DialogTab>
</t:tab>
<t:tab>
<t:DialogTab
ui:field="systemPermissionsTab">
<t:content>
- <g:FlowPanel>
- <g:SimplePanel
width="750px" ui:field="systemPermissionTabPanel" />
- </g:FlowPanel>
+ <g:SimplePanel addStyleNames="{style.panel}"
ui:field="systemPermissionTabPanel" />
</t:content>
</t:DialogTab>
</t:tab>
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
index 7174269..50ecb06 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
@@ -27,7 +27,7 @@
<g:Image resource='{resources.userImage}'
addStyleNames="{style.imageStyle}"/>
<g:RadioButton name="rolesRadioButton"
ui:field="userRolesRadioButton"/>
</g:HorizontalPanel>
- <g:SimplePanel ui:field="rolesTabContent" height="400px" />
+ <g:SimplePanel ui:field="rolesTabContent" height="495px" />
</g:VerticalPanel>
</ui:UiBinder>
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
index dd3cbfc..d842313 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
@@ -3,9 +3,12 @@
<ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui">
<ui:style>
-
+ .panel {
+ padding-right: 4px;
+ height: 525px;
+ }
</ui:style>
- <g:SimplePanel ui:field="tabContent" height="400px" />
+ <g:SimplePanel ui:field="tabContent" addStyleNames="{style.panel}" />
</ui:UiBinder>
--
To view, visit http://gerrit.ovirt.org/15473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I872e1b656dac03c146a806bdaf7fdcee4ef6fd26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
