Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: override get_target instead of new_client ......................................................................
novnc: override get_target instead of new_client seems to better follow the base class implementation, and does not duplicate communication logic into our code. Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Signed-off-by: Alon Bar-Lev <alo...@redhat.com> --- M packaging/services/ovirt-websocket-proxy.py 1 file changed, 9 insertions(+), 22 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
