Mike Kolesnik has posted comments on this change. Change subject: core: Add providedBy field to Network ......................................................................
Patch Set 22: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_03_0180_add_provided_by_to_network.sql Line 1: ALTER TABLE network ADD COLUMN provider_network_provider_id UUID CONSTRAINT fk_network_provided_by REFERENCES providers(id) ON DELETE CASCADE; I think on the DB level this is easier to differentiate as "logically" belonging to a different entity.. Line 2: ALTER TABLE network ADD COLUMN provider_network_external_id TEXT; Line 1: ALTER TABLE network ADD COLUMN provider_network_provider_id UUID CONSTRAINT fk_network_provided_by REFERENCES providers(id) ON DELETE CASCADE; Line 2: ALTER TABLE network ADD COLUMN provider_network_external_id TEXT; Yes it is the ID of the network on the provider, hence external ID. I can rename to "provider_network_external_network_id" if it makes more sense.. -- To view, visit http://gerrit.ovirt.org/10784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bab3b703ab9982956c25cc5deec91abda93afd7 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
