Michael Pasternak has posted comments on this change. Change subject: restapi: adding custom properties to vm interface ......................................................................
Patch Set 15: (1 inline comment) please add it as feature under backendcapabilitiesresource.features for 3.3 .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2493: <xs:element name="active" type="xs:boolean" minOccurs="0"/> <!-- Deprecated, replaced by 'plugged' --> Line 2494: <xs:element name="plugged" type="xs:boolean" minOccurs="0"/> Line 2495: <xs:element ref="port_mirroring" minOccurs="0" maxOccurs="1"/> Line 2496: <xs:element ref="reported_devices" minOccurs="0" maxOccurs="1"/> Line 2497: <xs:element name="custom_properties" type="CustomProperties" minOccurs="0"/> you could do just ref=custom_properties, explicit definition of name+type is valuable when you want to name element differently. Line 2498: </xs:sequence> Line 2499: </xs:extension> Line 2500: </xs:complexContent> Line 2501: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/15101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f5daae4b0b2117d0cadceb2bb292fabf445c3c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
