Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore Unwritten public fields ......................................................................
findbugs: ignore Unwritten public fields This classes are GWT classes and will generated code that will write to this fields findbugs reason: UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Signed-off-by: Shahar Havivi <[email protected]> --- A frontend/webadmin/modules/uicompat/exclude-filters.xml M frontend/webadmin/modules/uicompat/pom.xml 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/15403/1 diff --git a/frontend/webadmin/modules/uicompat/exclude-filters.xml b/frontend/webadmin/modules/uicompat/exclude-filters.xml new file mode 100644 index 0000000..dd2c0a1 --- /dev/null +++ b/frontend/webadmin/modules/uicompat/exclude-filters.xml @@ -0,0 +1,29 @@ +<FindBugsFilter> + <!-- + findbugs complain of using unwritten public field: EventArgs.Empty + This class is GWT generated code and its generated code will write + to this field + + findbugs reason: + UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) + --> + <Match> + <Class name="org.ovirt.engine.ui.uicompat.Enlistment" /> + <Method name="Done"/> + <Bug code="UwF"/> + </Match> + + <!-- + findbugs complain of using unwritten public field: Dispatcher.CurrentDispatcher + This class is GWT generated code and its generated code will write + to this field + + findbugs reason: + UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) + --> + <Match> + <Class name="org.ovirt.engine.ui.uicompat.Task" /> + <Method name="Task"/> + <Bug code="UwF"/> + </Match> + </FindBugsFilter> diff --git a/frontend/webadmin/modules/uicompat/pom.xml b/frontend/webadmin/modules/uicompat/pom.xml index 2dbe499..52b5284 100644 --- a/frontend/webadmin/modules/uicompat/pom.xml +++ b/frontend/webadmin/modules/uicompat/pom.xml @@ -66,6 +66,17 @@ </execution> </executions> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> </plugins> </build> </project> -- To view, visit http://gerrit.ovirt.org/15403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
