Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: support older psycopg2 ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/setup/ovirt_engine_setup/database.py Line 109: database=database, Line 110: sslmode=sslmode, Line 111: ) Line 112: Line 113: if not transaction: you are correct! I tried to be more friendly and to use transaction parameter, but you completely right, we cannot modify the state of the connection without restore. Line 114: # autocommit member is available at >= 2.4.2 Line 115: if hasattr(connection, 'autocommit'): Line 116: connection.autocommit = True Line 117: else: -- To view, visit http://gerrit.ovirt.org/15358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf94f83d3ebf5d121ef7bff3552bccfa09a99ec1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
