Frank Kobzik has posted comments on this change.

Change subject: engine: Integrate SPICE-HTML5 client
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/conf/engine.conf.defaults.in
Line 34: ENGINE_VAR="@ENGINE_VAR@"
Line 35: ENGINE_CACHE="@ENGINE_CACHE@"
Line 36: SPICE_DIR="@SPICE_DIR@"
Line 37: ENGINE_NOVNC_DIR="/usr/share/novnc"
Line 38: ENGINE_SPICE_HTML5_DIR="/usr/share/spice-html5"
(A little bit late answer - I forgot to post the review) And yes. This relies 
on an external rpm (in the same way as noVNC in the engine does).
Line 39: 
Line 40: #
Line 41: # Intervals for stoping the engine:
Line 42: #


--
To view, visit http://gerrit.ovirt.org/15257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I490cb57f5d23a7a763807d3bee00ea0e4c032338
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to