Ravi Nori has posted comments on this change.

Change subject: restapi : Add /applications sub-collection under vm(#926928)
......................................................................


Patch Set 6: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationResourceTest.java
Line 86:     public void testGet() throws Exception {
Line 87:         setUriInfo(setUpBasicUriExpectations());
Line 88:         setUpEntityQueryExpectations();
Line 89:         control.replay();
Line 90: 
Yes it works, setUpEntityQueryExpectations(); called in line 88 sets up the 
GetVmByVmId expectations
Line 91:         Application application = resource.get();
Line 92:         assertEquals(NAMES[APPLICATION_INDEX], application.getName());
Line 93:         verifyLinks(application);
Line 94:     }


....................................................
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationsResourceTest.java
Line 39: 
Line 40:     @Override
Line 41:     protected Object getEntity(int index) {
Line 42:         // TODO Auto-generated method stub
Line 43:         return null;
Not sure I understand your commend here Michael
Line 44:     }
Line 45: 
Line 46:     @Test
Line 47:     public void testList() throws Exception {


--
To view, visit http://gerrit.ovirt.org/13493
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7db49d2cc7b47c39ef3d4fff261a99c24dae42
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to