Allon Mureinik has posted comments on this change. Change subject: restapi - #755579: Return proper http status for errors ......................................................................
Patch Set 6: Looks good to me, but someone else must approve @Michael/Ori - it seems to me we don't disagree on the need to move AppErrors*.properties out of the dal package, just on whether it should be done in THIS patch or a separate one. As long as it's on your radar, I don't have a strong objection to separating it to a different patch. @Ori - please validate that this change does not break the UI, and we still get nicely replaced messages. (I agree it shouldn't, but, you know, assumptions are the mother of all...) -- To view, visit http://gerrit.ovirt.org/14498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I395e4b303eda174360ece709ddd7de6b1e3ce93f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
