Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Messages: dont use class name as the same as the
class you implement
......................................................................
findbugs: Messages: dont use class name as the same as the class you implement
class name Messages change to UIMessages
findbugs reason:
Nm: Class names shouldn't shadow simple name of implemented interface
(NM_SAME_SIMPLE_NAME_AS_INTERFACE)
Change-Id: I499a5f85a2b5c8881bf35a71d12e9a4460d5bd3f
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java
R
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
6 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/15310/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
index 4e4391f..33d1551 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
@@ -34,14 +34,14 @@
import org.ovirt.engine.ui.uicompat.FrontendMultipleActionAsyncResult;
import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback;
import org.ovirt.engine.ui.uicompat.IFrontendMultipleActionAsyncCallback;
-import org.ovirt.engine.ui.uicompat.Messages;
+import org.ovirt.engine.ui.uicompat.UIMessages;
import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
@SuppressWarnings("unused")
public class HostGeneralModel extends EntityModel
{
private static final UIConstants constants =
ConstantsManager.getInstance().getConstants();
- private static final Messages messages =
ConstantsManager.getInstance().getMessages();
+ private static final UIMessages messages =
ConstantsManager.getInstance().getMessages();
public static EventDefinition RequestEditEventDefinition;
private Event privateRequestEditEvent;
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
index 13393f4..85fa787 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
@@ -71,7 +71,7 @@
import org.ovirt.engine.ui.uicompat.IEventListener;
import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback;
import org.ovirt.engine.ui.uicompat.IFrontendMultipleActionAsyncCallback;
-import org.ovirt.engine.ui.uicompat.Messages;
+import org.ovirt.engine.ui.uicompat.UIMessages;
import org.ovirt.engine.ui.uicompat.NotifyCollectionChangedEventArgs;
import org.ovirt.engine.ui.uicompat.ObservableCollection;
import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
@@ -1146,7 +1146,7 @@
public void restart()
{
final UIConstants constants =
ConstantsManager.getInstance().getConstants();
- final Messages messages = ConstantsManager.getInstance().getMessages();
+ final UIMessages messages =
ConstantsManager.getInstance().getMessages();
ConfirmationModel model = new ConfirmationModel();
setConfirmWindow(model);
model.setTitle(constants.restartHostsTitle());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
index 110feb6..6c865a6 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
@@ -23,7 +23,7 @@
import org.ovirt.engine.ui.uicompat.Event;
import org.ovirt.engine.ui.uicompat.EventArgs;
import org.ovirt.engine.ui.uicompat.IEventListener;
-import org.ovirt.engine.ui.uicompat.Messages;
+import org.ovirt.engine.ui.uicompat.UIMessages;
import org.ovirt.engine.ui.uicompat.ObservableCollection;
import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
@@ -279,7 +279,7 @@
private void updateGrayedOut(LunModel lunModel) {
UIConstants constants = ConstantsManager.getInstance().getConstants();
- Messages messages = ConstantsManager.getInstance().getMessages();
+ UIMessages messages = ConstantsManager.getInstance().getMessages();
LUNs lun = (LUNs) lunModel.getEntity();
boolean nonEmpty = lun.getStorageDomainId() != null || lun.getDiskId()
!= null ||
@@ -606,7 +606,7 @@
public ArrayList<String> getUsedLunsMessages() {
ArrayList<String> usedLunsMessages = new ArrayList<String>();
- Messages messages = ConstantsManager.getInstance().getMessages();
+ UIMessages messages = ConstantsManager.getInstance().getMessages();
for (LunModel lunModel : getAddedLuns()) {
if (lunModel.getStatus() == LunStatus.Used) {
@@ -627,7 +627,7 @@
public ArrayList<String> getPartOfSdLunsMessages() {
ArrayList<String> partOfSdLunsMessages = new ArrayList<String>();
- Messages messages = ConstantsManager.getInstance().getMessages();
+ UIMessages messages = ConstantsManager.getInstance().getMessages();
for (LunModel lunModel : getAddedLuns()) {
String reason = null;
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
index 043207f..5eb2d18 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
@@ -7,7 +7,7 @@
import org.ovirt.engine.core.common.businessentities.Disk.DiskStorageType;
import org.ovirt.engine.ui.uicommonweb.models.Model;
import org.ovirt.engine.ui.uicompat.ConstantsManager;
-import org.ovirt.engine.ui.uicompat.Messages;
+import org.ovirt.engine.ui.uicompat.UIMessages;
import org.ovirt.engine.ui.uicompat.external.StringUtils;
public class VmModelHelper {
@@ -30,7 +30,7 @@
}
}
- final Messages messages = ConstantsManager.getInstance().getMessages();
+ final UIMessages messages =
ConstantsManager.getInstance().getMessages();
// check if VM provides any disk for the export
if (vmDisks.size() - (sharedImageDisks.size() + directLunDisks.size())
== 0) {
diff --git
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java
index 6e1f65c..8f60bf0 100644
---
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java
+++
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java
@@ -6,7 +6,7 @@
private static final ConstantsManager INSTANCE = new ConstantsManager();
private static final UIConstants constants = GWT.create(UIConstants.class);
- private static final Messages messages = GWT.create(Messages.class);
+ private static final UIMessages messages = GWT.create(UIMessages.class);
private ConstantsManager() {
}
@@ -19,7 +19,7 @@
return constants;
}
- public Messages getMessages() {
+ public UIMessages getMessages() {
return messages;
}
diff --git
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
similarity index 99%
rename from
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
rename to
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
index 4438ee5..3623c4f 100644
---
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
+++
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
@@ -3,7 +3,7 @@
import java.util.Date;
import java.util.List;
-public interface Messages extends com.google.gwt.i18n.client.Messages {
+public interface UIMessages extends com.google.gwt.i18n.client.Messages {
@DefaultMessage("One of the parameters isn''t supported (available
parameter(s): {0})")
String customPropertyOneOfTheParamsIsntSupported(String parameters);
--
To view, visit http://gerrit.ovirt.org/15310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I499a5f85a2b5c8881bf35a71d12e9a4460d5bd3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
