Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: Log interface should not be the same as the
implemented class name
......................................................................
findbugs: ignore: Log interface should not be the same as the implemented class
name
findbugs warns about using namespace interface 'Log' is the same name as the
implemented interface name 'Log'.
The class is deeply embedded in the code so we are ignoring findbugs warning
for now
Nm: Class names shouldn't shadow simple name of implemented interface
(NM_SAME_SIMPLE_NAME_AS_INTERFACE)
Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M backend/manager/modules/utils/exclude-filters.xml
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/15311/1
diff --git a/backend/manager/modules/utils/exclude-filters.xml
b/backend/manager/modules/utils/exclude-filters.xml
index 2d80a22..3e734d7 100644
--- a/backend/manager/modules/utils/exclude-filters.xml
+++ b/backend/manager/modules/utils/exclude-filters.xml
@@ -35,4 +35,18 @@
<Method name="parseOptions"/>
<Bug code="Dm"/>
</Match>
+
+ <!--
+ findbugs warns about using namespace interface 'Log' is the same name as
the
+ implemented interface name 'Log'.
+ The class is deeply embedded in the code so we are ignoring findbugs
warning
+ for now
+
+ findbugs reason:
+ Nm: Class names shouldn't shadow simple name of implemented interface
(NM_SAME_SIMPLE_NAME_AS_INTERFACE)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.core.utils.log.Log" />
+ <Bug code="Nm"/>
+ </Match>
</FindBugsFilter>
--
To view, visit http://gerrit.ovirt.org/15311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
