Alissa Bonas has posted comments on this change. Change subject: core: fix typos in CanDoActionTestUtils ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java Line 28: boolean canDoAction = command.canDoAction(); Line 29: List<String> canDoActionMessages = command.getReturnValue().getCanDoActionMessages(); Line 30: Line 31: assertFalse("Command's canDoAction expected to fail, but succeeded", canDoAction); Line 32: assertTrue(MessageFormat.format("canDoAction messages doesn't contain expected message: {0}, messages are: {1}", ok now I get it, good catch, thanks. Line 33: message.name(), Line 34: canDoActionMessages), Line 35: canDoActionMessages.contains(message.name())); Line 36: -- To view, visit http://gerrit.ovirt.org/15270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85f211c57df6febd6f79c5127a6eb97d38d2710 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches