Oved Ourfali has posted comments on this change. Change subject: findbugs: dont use static filed as public ......................................................................
Patch Set 2: these constants are used from the outside... that's why they are declared as public. just remove the "public", to make that package protected. Hopefully that would be enough for findbugs. -- To view, visit http://gerrit.ovirt.org/15287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d3d345fdd56faf1a7b9ae826924527f6fceff2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
