Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: static field should be final
......................................................................
findbugs: static field should be final
findbugs reason:
MS: Field isn't final but should be (MS_SHOULD_BE_FINAL)
Change-Id: I7c76a1d65ed7de7259f2355c0b37c38e4fc0fd08
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java
M
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
6 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/15308/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
index e472f2b..48941b0 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
@@ -17,7 +17,7 @@
public class VmTemplateHandler {
protected static Guid BlankVmTemplateId = new Guid();
- protected static String BlankVmTemplateName = "Blank";
+ protected final static String BlankVmTemplateName = "Blank";
private static ObjectIdentityChecker mUpdateVmTemplate;
/**
diff --git
a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java
b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java
index 8000c0c..cdbafd0 100644
---
a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java
+++
b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java
@@ -15,11 +15,11 @@
* This class contains useful session utils
*/
public class SessionUtils {
- public static String ENGINE_SESSION_ID_KEY = "engineSessionId";
- public static String PREFER_HEADER_FIELD = "Prefer";
- public static String SESSION_TTL_HEADER_FIELD = "Session-TTL";
- public static String PERSIST_FIELD_VALUE = "persistent-auth";
- public static String JSESSIONID_HEADER = "JSESSIONID";
+ public final static String ENGINE_SESSION_ID_KEY = "engineSessionId";
+ public final static String PREFER_HEADER_FIELD = "Prefer";
+ public final static String SESSION_TTL_HEADER_FIELD = "Session-TTL";
+ public final static String PERSIST_FIELD_VALUE = "persistent-auth";
+ public final static String JSESSIONID_HEADER = "JSESSIONID";
private static final Log log = LogFactory.getLog(SessionUtils.class);
/*
diff --git
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
index bb798c9..1116fcb 100644
---
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
+++
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
@@ -45,7 +45,7 @@
public class HostMapper {
- public static Long BYTES_IN_MEGABYTE = 1024L * 1024L;
+ public final static Long BYTES_IN_MEGABYTE = 1024L * 1024L;
// REVISIT retrieve from configuration
private static final int DEFAULT_VDSM_PORT = 54321;
private static final String MD5_FILE_SIGNATURE = "md5";
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
index 2bf3e39..aa038b3 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
@@ -90,11 +90,11 @@
private static VdcQueryType[] subscribedQueryTypes;
- public static EventDefinition QueryStartedEventDefinition = new
EventDefinition("QueryStarted", Frontend.class); //$NON-NLS-1$
- public static Event QueryStartedEvent = new
Event(QueryStartedEventDefinition);
+ public final static EventDefinition QueryStartedEventDefinition = new
EventDefinition("QueryStarted", Frontend.class); //$NON-NLS-1$
+ public final static Event QueryStartedEvent = new
Event(QueryStartedEventDefinition);
- public static EventDefinition QueryCompleteEventDefinition = new
EventDefinition("QueryComplete", Frontend.class); //$NON-NLS-1$
- public static Event QueryCompleteEvent = new
Event(QueryCompleteEventDefinition);
+ public final static EventDefinition QueryCompleteEventDefinition = new
EventDefinition("QueryComplete", Frontend.class); //$NON-NLS-1$
+ public final static Event QueryCompleteEvent = new
Event(QueryCompleteEventDefinition);
private static Event frontendFailureEvent = new Event("FrontendFailure",
Frontend.class); //$NON-NLS-1$
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
index d6a0532..5f7841f 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
@@ -25,7 +25,7 @@
privateRetrievedEvent = value;
}
- public static EventDefinition RetrievedEventDefinition;
+ public final static EventDefinition RetrievedEventDefinition;
private Guid privateId = new Guid();
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
index 3e783ee..56939b7 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
@@ -124,8 +124,8 @@
@Path(value = "unlinked_IsSelected.entity")
public EntityModelRadioButtonEditor unlinkedEditor;
- public static CommonApplicationTemplates templates =
GWT.create(CommonApplicationTemplates.class);
- public static CommonApplicationResources resources =
GWT.create(CommonApplicationResources.class);
+ public final static CommonApplicationTemplates templates =
GWT.create(CommonApplicationTemplates.class);
+ public final static CommonApplicationResources resources =
GWT.create(CommonApplicationResources.class);
@UiField
@Ignore
--
To view, visit http://gerrit.ovirt.org/15308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c76a1d65ed7de7259f2355c0b37c38e4fc0fd08
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
