[Engine-patches] Change in ovirt-engine[master]: findbugs: convert to double on integer values before casting...

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: findbugs: convert to double on integer values before casting 
them
......................................................................

findbugs: convert to double on integer values before casting them

Doing division on integers truncates the result to the integer value
closest to zero.

ICAST: integral division result cast to double or float 
(ICAST_IDIV_CAST_TO_DOUBLE)

Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/15281/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
index 6592b5f..435c53c 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java
@@ -25,7 +25,7 @@
         super(minValue, maxValue, formatter, resources);
         this.setNumLabels(9);
         this.setNumTicks(9);
-        this.setStepSize((maxValue - minValue + 1) / 10);
+        this.setStepSize(((double)maxValue - (double)minValue + 1f) / 10f);
         this.setPixelSize(166, 30);
     }
 
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
index db41f2b..207df08 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java
@@ -816,7 +816,7 @@
         int lineWidth = lineElement.getOffsetWidth();
         int knobWidth = knobElement.getOffsetWidth();
         int knobLeftOffset = (int) (lineLeftOffset
-                + (getKnobPercent() * lineWidth) - (knobWidth / 2));
+                + ((int)getKnobPercent() * lineWidth) - (knobWidth / 2));
         knobLeftOffset = Math.min(knobLeftOffset, lineLeftOffset + lineWidth
                 - (knobWidth / 2) - 1);
         DOM.setStyleAttribute(knobElement, "left", knobLeftOffset + "px"); 
//$NON-NLS-1$ //$NON-NLS-2$


--
To view, visit http://gerrit.ovirt.org/15281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches