Daniel Erez has uploaded a new change for review. Change subject: core: adding disk_id as a secondary order-by column ......................................................................
core: adding disk_id as a secondary order-by column Disks search default order by column is disk_alias. Since disk alias is not unique, the search query might return disks in a different order when they are manipulated (e.g. status changes). Hence, in order to prevent unpredicted order, added disk_id as a secondary order-by column. Change-Id: I7e62b44cab4065c41dc7273fc527415b9fba002f Bug-Url: https://bugzilla.redhat.com/953154 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/15264/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java index f080fa2..cb92b98 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java @@ -222,7 +222,7 @@ "all_disks", "all_disks", "disk_id", - "disk_alias ASC ")); + "disk_alias ASC, disk_id ASC ")); put(SearchObjects.VDC_STORAGE_DOMAIN_OBJ_NAME, new EntitySearchInfo(new StorageDomainCrossRefAutoCompleter(), new StorageDomainFieldAutoCompleter(), @@ -236,7 +236,7 @@ null, "vm_images_storage_domains_view", "image_guid", - "disk_alias ASC ")); + "disk_alias ASC, disk_id ASC ")); put(SearchObjects.GLUSTER_VOLUME_OBJ_NAME, new EntitySearchInfo(GlusterVolumeCrossRefAutoCompleter.INSTANCE, GlusterVolumeConditionFieldAutoCompleter.INSTANCE, -- To view, visit http://gerrit.ovirt.org/15264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e62b44cab4065c41dc7273fc527415b9fba002f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
