Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Adding EndExternalStepCommand
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java
Line 21:
Line 22: @Override
Line 23: protected boolean canDoAction() {
Line 24: boolean retValue=true;
Line 25: step =
DbFacade.getInstance().getStepDao().get(getParameters().getId());
Same comment about getStepDao
Line 26: if (step == null) {
Line 27: retValue=false;
Line 28: //TODO add message
Line 29: }
Line 33: }
Line 34: job = DbFacade.getInstance().getJobDao().get(step.getJobId());
Line 35: if (job == null) {
Line 36: retValue=false;
Line 37: //TODO add message
Remove todo, unless it's real one ?:)
Line 38: }
Line 39: return retValue;
Line 40: }
Line 41:
Line 56: }
Line 57:
Line 58: @Override
Line 59: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 60: // TODO Auto-generated method stub
Same as previous questions on permissions.
Line 61: return null;
Line 62: }
Line 63:
--
To view, visit http://gerrit.ovirt.org/15229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ec56890dcfc9dbfc5b53c6ccc9bceb411a98402
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
