Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: Adding AddExternalJobCommand command ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties Line 548: RELOAD_CONFIGURATIONS_FAILURE=System Configurations failed to reload. Line 549: USER_ACCOUNT_DISABLED_OR_LOCKED=User ${UserName} cannot login, as it got disabled or locked. Please contact the system administrator. Line 550: USER_ACCOUNT_PASSWORD_EXPIRED=User ${UserName} cannot login, as the user account password has expired. Please contact the system administrator. Line 551: ENTITY_RENAMED=${EntityType} ${OldEntityName} was renamed from ${OldEntityName} to ${NewEntityName}. Line 552: USER_ADD_EXTERNAL_JOB=New external Job ${description} was added by user ${UserName} I see that "job" is mentioned at audit log only here. As this is presented to user, maybe we should ask PM what they think? Is user aware to "job" concept in any other way in the system? I think that even with current Task Monitoring he is not aware to the term "job". Line 553: USER_ADD_EXTERNAL_JOB_FAILED=Failed to add new external Job ${description} Line 554: STORAGE_DOMAIN_TASKS_ERROR=Storage Domain ${StorageDomainName} is down while there are tasks running on it. These tasks may fail. Line 555: IMPORTEXPORT_IMPORT_VM_INVALID_INTERFACES=While importing VM ${VmName}, the Network/s ${Networks} were found to be Non-VM Networks or do not exist in Cluster. Network Name was not set in the Interface/s ${Interfaces}. Line 556: IMPORTEXPORT_IMPORT_TEMPLATE_INVALID_INTERFACES=While importing Template ${VmTemplateName}, the Network/s ${Networks} were found to be Non-VM Networks or do not exist in Cluster. Network Name was not set in the Interface/s ${Interfaces}. -- To view, visit http://gerrit.ovirt.org/15226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91604386 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches