Kanagaraj M has posted comments on this change.
Change subject: gluster: Added query for gluster cluster service
......................................................................
Patch Set 1: (1 inline comment)
frontend AppErrors.java is missing.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterClusterServiceQueryParameters.java
Line 12: private ServiceType serviceType;
Line 13:
Line 14: public GlusterClusterServiceQueryParameters(Guid groupId) {
Line 15: super(groupId);
Line 16: }
As the serviceType is a mandatory field, i would prefer adding that as a
constructor argument.
Line 17:
Line 18: public ServiceType getServiceType() {
Line 19: return serviceType;
Line 20: }
--
To view, visit http://gerrit.ovirt.org/15241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I123e39fde8317a9227a1bd008c5afbc5dcb7691d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
