Sahina Bose has posted comments on this change. Change subject: gluster:Remove gluster hook from servers ......................................................................
Patch Set 3: (2 inline comments) Updated patchset to follow .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java Line 40: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__GLUSTER_HOOK); Line 41: } Line 42: Line 43: private List<VDS> getServersInCluster() { Line 44: return getVdsDAO().getAllForVdsGroup(getGlusterHook().getClusterId()); Yes. will do. Line 45: } Line 46: Line 47: @Override Line 48: protected boolean canDoAction() { Line 86: } Line 87: }); Line 88: } Line 89: Line 90: setSucceeded(true); Ok. Done Line 91: if (!taskList.isEmpty()) { Line 92: List<Pair<VDS, VDSReturnValue>> pairResults = ThreadPoolUtil.invokeAll(taskList); Line 93: for (Pair<VDS, VDSReturnValue> pairResult : pairResults) { Line 94: -- To view, visit http://gerrit.ovirt.org/15153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic38f9edbc45a8e92b65a4a61c99b647cadb8feb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches