Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: findbugs complain of unused field in class.
......................................................................
findbugs: ignore: findbugs complain of unused field in class.
This is a GWT classes and use to generate code
findbugs reason:
UuF: Unused field (UUF_UNUSED_FIELD)
Change-Id: I536a80c26a03bb263dc6a2e667cfa762fdf29bd5
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
A frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/gwt-common/pom.xml
A frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
5 files changed, 346 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/15204/1
diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
new file mode 100644
index 0000000..e941a9b
--- /dev/null
+++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
@@ -0,0 +1,49 @@
+<FindBugsFilter>
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.common.presenter.popup.ConsoleModelChanged" />
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.common.presenter.RedrawDynamicTabContainer" />
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.common.uicommon.model.MainModelSelectionChange" />
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.ui.common.system.ApplicationFocusChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+ </FindBugsFilter>
diff --git a/frontend/webadmin/modules/gwt-common/pom.xml
b/frontend/webadmin/modules/gwt-common/pom.xml
index 5a7d802..f9a56f5 100644
--- a/frontend/webadmin/modules/gwt-common/pom.xml
+++ b/frontend/webadmin/modules/gwt-common/pom.xml
@@ -134,6 +134,17 @@
<propertyExpansion>runNlsCheck=true</propertyExpansion>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
+ </plugin>
</plugins>
</build>
</project>
diff --git a/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
new file mode 100644
index 0000000..18b3e58
--- /dev/null
+++ b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
@@ -0,0 +1,37 @@
+<FindBugsFilter>
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.userportal.section.main.presenter.SearchableModelActivation"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.ExtendedTemplateSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.ExtendedVirtualMachineSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+ </FindBugsFilter>
diff --git a/frontend/webadmin/modules/userportal-gwtp/pom.xml
b/frontend/webadmin/modules/userportal-gwtp/pom.xml
index 28d87b4..70b933b 100644
--- a/frontend/webadmin/modules/userportal-gwtp/pom.xml
+++ b/frontend/webadmin/modules/userportal-gwtp/pom.xml
@@ -196,6 +196,17 @@
<propertyExpansion>runNlsCheck=true</propertyExpansion>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
+ </plugin>
</plugins>
</build>
<profiles>
@@ -218,6 +229,17 @@
</goals>
</execution>
</executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
</plugin>
</plugins>
</build>
@@ -275,6 +297,17 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
+ </plugin>
</plugins>
</build>
</profile>
diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml
b/frontend/webadmin/modules/webadmin/exclude-filters.xml
index f822d9d..f5c9123 100644
--- a/frontend/webadmin/modules/webadmin/exclude-filters.xml
+++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml
@@ -9,4 +9,220 @@
<Method name="getResultAsBoolean"/>
<Bug code="NP"/>
</Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.plugin.restapi.RestApiSessionAcquired" />
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.UpdateMainContentLayout"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.CloseDynamicPopup"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabClusterPresenter.ClusterSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabDataCenterPresenter.DataCenterSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabDiskPresenter.DiskSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabEventPresenter.EventSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabHostPresenter.HostSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabNetworkPresenter.NetworkSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabPoolPresenter.PoolSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabProviderPresenter.ProviderSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabQuotaPresenter.QuotaSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabStoragePresenter.StorageSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabTemplatePresenter.TemplateSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabUserPresenter.UserSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabVirtualMachinePresenter.VirtualMachineSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabVolumePresenter.VolumeSelectionChange"
/>
+ <Bug code="UuF"/>
+ </Match>
+
+ <!--
+ findbugs complain of unused field in class.
+ This is a GWT class and use to generate code
+
+ findbugs reason:
+ UuF: Unused field (UUF_UNUSED_FIELD)
+ -->
+ <Match>
+ <Class name="org.ovirt.engine.ui.webadmin.system.MessageReceived" />
+ <Bug code="UuF"/>
+ </Match>
</FindBugsFilter>
--
To view, visit http://gerrit.ovirt.org/15204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I536a80c26a03bb263dc6a2e667cfa762fdf29bd5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
