Arik Hadas has posted comments on this change. Change subject: core: [WIP] extract general code from HibernateVmCommand ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java Line 515: Line 516: return (cdList.size() > 1 || floppyList.size() > 1); Line 517: } Line 518: Line 519: public static StorageDomain findStorageDomainForMemory(Guid storagePoolId, long sizeRequested) { Done Line 520: List<StorageDomain> domainsInPool = DbFacade.getInstance().getStorageDomainDao().getAllForStoragePool(storagePoolId); Line 521: if (domainsInPool.size() > 0) { Line 522: for (StorageDomain currDomain : domainsInPool) { Line 523: if ((currDomain.getStorageDomainType().equals(StorageDomainType.Master) -- To view, visit http://gerrit.ovirt.org/14290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15c4f3302d26eb5d161824f8bb19ecc5dd114a20 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches