Omer Frenkel has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 9: private Version compatbilityVersion;
Line 10:
Line 11: public GetTaskListCommandParameters() {
Line 12: storagePoolId = null;
Line 13: compatbilityVersion = null;
no reason to explicitly set to null, its default behavior
Line 14: }
Line 15:
Line 16: public GetTaskListCommandParameters(Guid vdsId) {
Line 17: super(vdsId);
Line 15:
Line 16: public GetTaskListCommandParameters(Guid vdsId) {
Line 17: super(vdsId);
Line 18: storagePoolId = null;
Line 19: compatbilityVersion = null;
same here, or call this(,,)
Line 20: }
Line 21:
Line 22: public GetTaskListCommandParameters(Guid vdsId, Guid spUUID,
Version compatibilityVersion) {
Line 23: super(vdsId);
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1635: if (storagePool != null) {
Line 1636: return storagePool.getcompatibility_version();
Line 1637: } else {
Line 1638: log.errorFormat(
Line 1639: "IrsBroker::getStoragePoolClusterLevel:: Could
not find master domain for pool {0} !!!",
i think this message is not related to the error, also no reason to mention the
package, it will be there already
Line 1640: getParameters().getStoragePoolId());
Line 1641: return null;
Line 1642: }
Line 1643: }
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
