Shahar Havivi has uploaded a new change for review. Change subject: findbugs: unsynchronized initialization of non-volatile static field ......................................................................
findbugs: unsynchronized initialization of non-volatile static field This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions we need to make the field volatile findbugs reason: LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC) Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/15180/1 diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java index fb27c20..ed80c95 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java @@ -17,7 +17,7 @@ protected static final Log LOG = LogFactory.getLog(DateMapper.class); protected static final String DATATYPE_FACTORY_CREATION_FAILED = "DatatypeFactory creation failed"; - private static DatatypeFactory datatypeFactory; + private volatile static DatatypeFactory datatypeFactory; /** * Class-level synchronization to avoid potential thread-safety issues diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java index 229315d..43c7b1a 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java @@ -13,7 +13,7 @@ public class TypeConversionHelper { - private static DatatypeFactory datatypeFactory; + private volatile static DatatypeFactory datatypeFactory; protected static final Log LOG = LogFactory.getLog(SnapshotMapper.class); protected static final String DATATYPE_FACTORY_CREATION_FAILED = "DatatypeFactory creation failed"; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java index 6cb959d..a793a37 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java @@ -2805,8 +2805,8 @@ return false; } - private static ArrayList<VmOsType> linuxOsTypes; - private static ArrayList<VmOsType> x64OsTypes; + private volatile static ArrayList<VmOsType> linuxOsTypes; + private volatile static ArrayList<VmOsType> x64OsTypes; public static boolean isLinuxOsType(VmOsType osType) { -- To view, visit http://gerrit.ovirt.org/15180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
