Yair Zaslavsky has posted comments on this change.
Change subject: restapi: #838270 - Support View Of System Configuration
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
Line 23: public static <T> T GetValue(ConfigValues value, String version) {
Line 24: return getConfigUtils().<T> GetValue(value, version);
Line 25: }
Line 26:
Line 27: public static <T> T GetValue(ConfigValues value, String version,
boolean includeGenerated) {
Please explain at commit msg what includeGenerated is.
Line 28: return getConfigUtils().<T> GetValue(value, version,
includeGenerated);
Line 29: }
Line 30:
Line 31: public static <T> T GetValue(ConfigurationValues value) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValuesQueryParameters.java
Line 10: public GetConfigurationValuesQueryParameters(boolean
includeGenerated) {
Line 11: this.includeGenerated = includeGenerated;
Line 12: }
Line 13:
Line 14: public boolean isIncludeGenerated() {
Not clear what this property mean "includeGenerated"
Line 15: return includeGenerated;
Line 16: }
Line 17:
Line 18: public void setIncludeGenerated(boolean includeGenerated) {
--
To view, visit http://gerrit.ovirt.org/11468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5cf3a09cfbf4bfb7586ba296e13f71386c396f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
