Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 21: public Guid getStoragePoolId() {
Line 22: return spUUID;
Line 23: }
Line 24:
Line 25: public GetTaskListCommandParameters() {
guess not.. but we do it almost for all the parameter classes, so I copied. I
need only the second one. I'll omit the other 2 for now
Line 26: spUUID = null;
Line 27: }
Line 28:
Line 29: @Override
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksInfoVDSCommand.java
Line 19: @Override
Line 20: protected void ExecuteVdsBrokerCommand() {
Line 21: _result = null;
Line 22: if (getParameters().getStoragePoolId() != null) {
Line 23: if
(FeatureSupported.saferGetAllTasksRequest(getVds().getVdsGroupCompatibilityVersion()))
{
log is redundant here .. we know in which cluster level we run, we don't need
log for each call.. getVdsGroupCompatibilityVersion is the dc level that the
host runs on .. I guess you mixed with getSupportedClusterVersionsSet
Line 24: _result =
getBroker().getAllTasksInfo(getParameters().getStoragePoolId().toString());
Line 25: }
Line 26: }
Line 27: if (_result == null) {
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
