Shahar Havivi has uploaded a new change for review.

Change subject: findbugs: ignore: ignore unused host variable in parse dns 
record
......................................................................

findbugs: ignore: ignore unused host variable in parse dns record

findbugs complains that host variable is never used
its true but this method parse host and port and we may
need the use of host address in the future.

findbugs reason:
DLS: Dead store to local variable (DLS_DEAD_LOCAL_STORE)

Change-Id: Iab73f4f2b502af08e8485e00a20c974d1a472433
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M backend/manager/modules/common/exclude-filters.xml
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/15096/1

diff --git a/backend/manager/modules/common/exclude-filters.xml 
b/backend/manager/modules/common/exclude-filters.xml
index 71730fc..a27e8fb 100644
--- a/backend/manager/modules/common/exclude-filters.xml
+++ b/backend/manager/modules/common/exclude-filters.xml
@@ -14,4 +14,18 @@
        <Method name="clone"/>
        <Bug code="CN"/>
      </Match>
+
+     <!--
+      findbugs complains that host variable is never used
+      its true but this method parse host and port and we may
+      need the use of host address in the future.
+
+      findbugs reason:
+      DLS: Dead store to local variable (DLS_DEAD_LOCAL_STORE)
+     -->
+     <Match>
+       <Class name="org.ovirt.engine.core.utils.dns.DnsSRVLocator" />
+       <Method name="parseSrvRecord"/>
+       <Bug code="DLS"/>
+     </Match>
 </FindBugsFilter>


--
To view, visit http://gerrit.ovirt.org/15096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab73f4f2b502af08e8485e00a20c974d1a472433
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to