Frank Kobzik has posted comments on this change.

Change subject: engine: Integrate noVNC support
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 63:         if self.verbose and not self.daemon:
Line 64:             print(self.traffic_legend)
Line 65: 
Line 66:         # Start proxying
Line 67:         try:
hmm, i've just tried it with two simultaneous sessions and it worked.
Line 68:             self.do_proxy(tsock)
Line 69:         except:
Line 70:             if tsock:
Line 71:                 tsock.shutdown(socket.SHUT_RDWR)


--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Martin Beták <mbe...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to