Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: add ignore for super.clone from VDS.clone method ......................................................................
findbugs: ignore: add ignore for super.clone from VDS.clone method findbugs complains that VDS clone() method is not calling it super class clone() method. we cannot call super.close() because this code compile to GWT as well, and GWT does not support CloneNotSupportedException which is thrown when adding this code. findbugs reason: CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Signed-off-by: Shahar Havivi <[email protected]> --- A backend/manager/modules/common/exclude-filters.xml M backend/manager/modules/common/pom.xml 2 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/15083/1 diff --git a/backend/manager/modules/common/exclude-filters.xml b/backend/manager/modules/common/exclude-filters.xml new file mode 100644 index 0000000..71730fc --- /dev/null +++ b/backend/manager/modules/common/exclude-filters.xml @@ -0,0 +1,17 @@ +<FindBugsFilter> + <!-- + findbugs complains that VDS clone() method is not calling it super class clone() + method. + we cannot call super.close() because this code compile to GWT as well, + and GWT does not support CloneNotSupportedException which is thrown + when adding this code. + + findbugs reason: + CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) + --> + <Match> + <Class name="org.ovirt.engine.core.common.businessentities.VDS" /> + <Method name="clone"/> + <Bug code="CN"/> + </Match> +</FindBugsFilter> diff --git a/backend/manager/modules/common/pom.xml b/backend/manager/modules/common/pom.xml index 04e70db..d577435 100644 --- a/backend/manager/modules/common/pom.xml +++ b/backend/manager/modules/common/pom.xml @@ -99,6 +99,18 @@ <artifactId>jboss-modules-maven-plugin</artifactId> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> + </plugins> </build> </project> -- To view, visit http://gerrit.ovirt.org/15083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
