Alon Bar-Lev has posted comments on this change.
Change subject: core: [WIP] Manage OS properties in a repository
......................................................................
Patch Set 1: (2 inline comments)
Where is the script that creates the properties file?
Please move 00-os.properties to packaging/conf.
....................................................
File backend/manager/modules/bll/src/main/resources/00-os.properties
Line 23: #
Line 24:
Line 25: # for compatibility reasons and convenience an OS has an id.
Line 26: # note: every OS has a unique namespace for the native unique
representation of the data.
Line 27: # i.e os.rhel6.somekey = val belongs only to rhel6
spaces
Line 28: # Both engine and DWH rely on id value and not the os.{osid).*
Line 29: os.default.id.value = 0
Line 30:
Line 31: # name is I18N if the one creates a 01-os_${LOCALE}.properties with
the co-responding name property
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java
Line 34: private Log log = LogFactory.getLog(OsInfoPreferencesLoader.class);
Line 35:
Line 36:
Line 37: public void init() {
Line 38: String configPath =
LocalConfig.getInstance().getUsrDir().getPath() + "/conf/oss.conf.d";
This should probably be:
new File(EngineLocalConfig.getInstance.getEtcDir(), "osinfo.conf.d")
Line 39: load(FileSystems.getDefault().getPath(configPath));
Line 40: }
Line 41:
Line 42: public void load(Path directoryPath) {
--
To view, visit http://gerrit.ovirt.org/15080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
