Noam Slomianko has posted comments on this change.

Change subject: engine: add comment field to DataCenter
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 3: --
Line 4: 
Line 5: 
Line 6: Create or replace FUNCTION Insertstorage_pool(v_description 
VARCHAR(4000),
Line 7:         v_comment VARCHAR(4000),
Done

Ill change it
Line 8:         v_id UUID,
Line 9:         v_name VARCHAR(40),
Line 10:        v_storage_pool_type INTEGER,
Line 11:        v_status INTEGER,


....................................................
File backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql
Line 1: select fn_db_add_column('storage_pool', 'comment', 'VARCHAR(4000) 
default ''''');
Ok then,
I mean its either way... and i just don't like null.
ill remove it


....................................................
Commit Message
Line 5: CommitDate: 2013-05-20 15:11:23 +0300
Line 6: 
Line 7: engine: add comment field to DataCenter
Line 8: 
Line 9: As part of the Free Text FRE
Its in the Bug-url
Line 10: 
Line 11: Added to the entities flow in the system
Line 12: DB <-> DAO <-> Entity <-> Model <-> UI
Line 13: DB <-> DAO <-> Entity <-> REST


--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to