Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: clone does not call super clone method
......................................................................
findbugs: clone does not call super clone method
findbugs reason:
CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL)
Signed-off-by: Shahar Havivi <shav...@redhat.com>
Change-Id: Idfe05e69c8cde480c4cba93a1ce185691d9d9316
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/15059/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
index 154df6d..64f185d 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
@@ -53,6 +53,7 @@
@Override
public QuotaConsumptionParametersWrapper clone() throws
CloneNotSupportedException {
+ super.clone();
QuotaConsumptionParametersWrapper cloneWrapper = new
QuotaConsumptionParametersWrapper(getAuditLogable(),
canDoActionMessages);
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
index 92787de..b3d3e6b 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
@@ -186,6 +186,11 @@
}
public VDS clone() {
+ try {
+ super.clone();
+ } catch (CloneNotSupportedException e) {
+ // no need to handle the exception
+ }
VDS vds =
new VDS(Guid.createGuidFromString(getVdsGroupId().toString()),
getVdsGroupName(),
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
index d15012e..655ccc2 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
@@ -28,7 +28,8 @@
public void addOptionalArgument(Object name, Object type) {
optionalArguments.put(name,type);
}
- public Signature clone() {
+ public Signature clone() throws CloneNotSupportedException {
+ super.clone();
Signature clonedSignature = new Signature();
Map<Object, Object> mandatoryArguments = new HashMap<Object, Object>();
mandatoryArguments.putAll(getMandatoryArguments());
--
To view, visit http://gerrit.ovirt.org/15059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfe05e69c8cde480c4cba93a1ce185691d9d9316
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
