Yair Zaslavsky has posted comments on this change.
Change subject: engine : Fail tasks that dont have Vdsm Id
......................................................................
Patch Set 12: (2 inline comments)
I have two questions here, maybe worth adding more explanation to commit msg +
comments in the code.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
Line 73: protected boolean processImageInIrs() {
Line 74: Guid taskId =
this.createAsyncTask(getParameters().getParentCommand(),
Line 75: VdcObjectType.Storage,
Line 76: getParameters().getStorageDomainId());
Line 77: getReturnValue().getAsyncTaskIdList().add(taskId);
Should we add the task id on the task id list at this stage, and not after the
task is created at vdsm?
Line 78:
Line 79: VDSReturnValue vdsReturnValue = runVdsCommand(
Line 80: VDSCommandType.CreateImage,
Line 81: new
CreateImageVDSCommandParameters(getParameters().getStoragePoolId(),
getParameters()
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
Line 16: private boolean _succeeded;
Line 17: private boolean _isSyncronious;
Line 18: private Object _returnValue;
Line 19: private String _description = "";
Line 20: private ArrayList<Guid> asyncTaskIdList = new ArrayList<Guid>();
Hi, I saw you fix the names in the next patch.
I understand - I would suggest adding a comment here, or at commit message
explaining this.
Line 21: private ArrayList<Guid> taskIdList = new ArrayList<Guid>();
Line 22: private final ArrayList<Guid> _internalIdList = new
ArrayList<Guid>();
Line 23: private boolean _endActionTryAgain = true;
Line 24: private final ArrayList<String> _executeFailedMessages = new
ArrayList<String>();
--
To view, visit http://gerrit.ovirt.org/14368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I110c483842027d1596f64dd8c3f635d62924a93f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
