Emily Zhang has posted comments on this change.

Change subject: tools: Trusted Compute Pools - Open Attestation integration 
with oVirt engine proposal
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1287:     public void setTransparentHugePages(boolean value) {
Line 1288:         this.transparentHugePages = value;
Line 1289:     }
Line 1290: 
Line 1291:     private boolean trustedService;
Done
Line 1292: 
Line 1293:     public void setTrustedService(boolean trustedService) {
Line 1294:         this.trustedService = trustedService;
Line 1295:     }


Line 1293:     public void setTrustedService(boolean trustedService) {
Line 1294:         this.trustedService = trustedService;
Line 1295:     }
Line 1296: 
Line 1297:     public boolean supportsTrustedService() {
Done
Line 1298:         return trustedService;
Line 1299:     }
Line 1300: 
Line 1301:     @Override


....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 165: 
Line 166:        node = content.SelectSingleNode("TrustedService");
Line 167:        if (node != null) {
Line 168:            
_vmTemplate.setTrustedService(Boolean.parseBoolean(node.InnerText));
Line 169:        }
Maor, greate thanks for your promptings and it will be very helpful for us. We 
have not found this format file before, and we will format the code with it in 
the following days.
Line 170:     }
Line 171: 
Line 172:     @Override
Line 173:     protected String getDefaultDisplayTypeStringRepresentation() {


--
To view, visit http://gerrit.ovirt.org/14729
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f42f848798706be58acf1291c1841da1135d76d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com>
Gerrit-Reviewer: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to