Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated setup to preserve entered ISO path
......................................................................
Patch Set 1: (1 inline comment)
I don't understand... do you want to present the last entered value? we do not
do that for any of the field, and I think this is correct.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py
Line 260: self.environment[
Line 261: osetupcons.ConfigEnv.
Line 262: ISO_DOMAIN_DEFAULT_NFS_MOUNT_POINT
Line 263: ]
Line 264: )
don't like using or for if else.
Line 265: if os.path.exists(default_mount_point):
Line 266: default_mount_point += '-%s' % (
Line 267:
datetime.datetime.utcnow().strftime('%Y%m%d%H%M%S')
Line 268: )
--
To view, visit http://gerrit.ovirt.org/15033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbab043e9f2f89b2043101ae7d86a5e9c26f36f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
