Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support. ......................................................................
Patch Set 15: Now that we have ovirt branding as own package, we can refer to it in README.branding, making it much shorter, right? I would like to complete one more step toward formalizing an interface. We have the following styles: active activeMiddle activeMiddleLink barOuter borderPanelStyle content dialogHeaderImage dialogLogoErrorImage dialogLogoImage diskTypePanel headerCenterPanel inactiveMiddle loginPopupHeaderCenter loginPopupHeaderImage loginPopupHeaderLogoImage logo mainBarPanel storageTypePanel topPanel verticalTab .activeMiddle verticalTab .inactiveMiddleLink wrapper wrapperInner wrapperOuter These styles are part of the branding interface from now on. We need to create a clear differentiation between these and any internal style, as these should not be modified, or modified with caution. I suggest obrand prefix to be added to these, so it will be clear these part of the interface for both developers of the engine and developer of branding packages. Same for messaging, we correctly have: common.* userportal.* webadmin.* I suggest to add 'obrand.' prefix for these messages for the above reason. Thank you! -- To view, visit http://gerrit.ovirt.org/13181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
