Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Network Provider main tab
......................................................................
Patch Set 18: (10 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 813: list.add(networkList);
Line 814:
Line 815: providerList = new ProviderListModel();
Line 816: list.add(providerList);
Line 817:
what about the search?
Line 818: setItems(list);
Line 819:
Line 820: roleListModel = new RoleListModel();
Line 821: systemPermissionListModel = new SystemPermissionListModel();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java
Line 18: @Override
Line 19: protected void onEntityChanged() {
Line 20: super.onEntityChanged();
Line 21:
Line 22: if (super.getEntity() != null)
super is redundant
Line 23: {
Line 24: updateProperties();
Line 25: }
Line 26: }
Line 19: protected void onEntityChanged() {
Line 20: super.onEntityChanged();
Line 21:
Line 22: if (super.getEntity() != null)
Line 23: {
does this block formatted?
Line 24: updateProperties();
Line 25: }
Line 26: }
Line 27:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
Line 20: import org.ovirt.engine.ui.uicompat.ObservableCollection;
Line 21:
Line 22: public class ProviderListModel extends ListWithDetailsModel implements
ISupportSystemTreeContext
Line 23: {
Line 24: private UICommand addCommand;
consider changing to newCommand (and set/getter)
Line 25: private UICommand removeCommand;
Line 26:
Line 27: private SystemTreeItemModel systemTreeSelectedItem;
Line 28:
Line 89: protected void asyncSearch() {
Line 90: // super.AsyncSearch();
Line 91: //
Line 92: // setAsyncResult(Frontend.RegisterSearch(getSearchString(),
SearchType.Provider, getSearchPageSize()));
Line 93: // setItems(getAsyncResult().getData());
no need for this method, actually there is a pending cleanup for it.
Line 94: }
Line 95:
Line 96: @Override
Line 97: protected void onSelectedItemChanged() {
Line 117: public void executeCommand(UICommand command) {
Line 118: super.executeCommand(command);
Line 119:
Line 120: if (command == getAddCommand())
Line 121: {
does this block formatted or is it a gerrit bug in preview?
Line 122: add();
Line 123: }
Line 124: else if (command == getRemoveCommand())
Line 125: {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java
Line 34: UICommand lastExecutedCommand, Model windowModel) {
Line 35:
Line 36: // if (lastExecutedCommand ==
getModel().getAddCommand()) {
Line 37: // return editNetworkPopupProvider.get();
Line 38: // } else {
remove comments
Line 39: return super.getModelPopup(source,
lastExecutedCommand, windowModel);
Line 40: // }
Line 41: }
Line 42:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java
Line 28: ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class);
Line 29: }
Line 30:
Line 31: interface Driver extends
SimpleBeanEditorDriver<ProviderGeneralModel, SubTabProviderGeneralView> {
Line 32: Driver driver = GWT.create(Driver.class);
please take a look in 4bae3be384992156868a97c689df2e979f855aea
Line 33: }
Line 34:
Line 35: private final ApplicationConstants constants =
ClientGinjectorProvider.instance().getApplicationConstants();
Line 36:
Line 48: // Init formPanel
Line 49: formPanel = new GeneralFormPanel();
Line 50:
Line 51: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 52: Driver.driver.initialize(this);
same
Line 53:
Line 54: // Build a form using the FormBuilder
Line 55: formBuilder = new FormBuilder(formPanel, 1, 1);
Line 56:
Line 58: }
Line 59:
Line 60: @Override
Line 61: public void setMainTabSelectedItem(Provider selectedItem) {
Line 62: Driver.driver.edit(getDetailModel());
same
Line 63: formBuilder.update(getDetailModel());
Line 64: }
Line 65:
--
To view, visit http://gerrit.ovirt.org/11114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
