Eli Mesika has posted comments on this change. Change subject: core: Adding fnSplitterMap function ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (3 inline comments) .................................................... File backend/manager/dbscripts/create_functions.sql Line 48: RETURNS SETOF mapEntryType Line 49: AS $function$ Line 50: BEGIN Line 51: -- Checks if mapText contains a valid map string. A valid map string is a string that Line 52: ---is comma delimited and that each one of the parts is in the format of key=value the=>its Line 53: IF mapText != '' AND mapText ~ '([[:alnum:]])+(=)+([[:alnum:]])+(,([[:alnum:]])+(=)+([[:alnum:]]))*' THEN Line 54: RETURN QUERY Line 55: SELECT substr(splitted,1,position('=' in splitted)-1) as map_key,substr(splitted,position('=' in splitted)+1) as map_value FROM Line 56: (SELECT regexp_split_to_table(mapText, ',') as splitted) as subquery; .................................................... Commit Message Line 5: CommitDate: 2013-05-21 10:06:04 +0300 Line 6: Line 7: core: Adding fnSplitterMap function Line 8: Line 9: This function accepts as argument a command delimited comma Line 10: string that each of its parts is a key value pair (key=value) Line 11: Line 12: For example: Line 13: select fnSplitterMap('123=VM,456=Storage'); Line 9: This function accepts as argument a command delimited Line 10: string that each of its parts is a key value pair (key=value) Line 11: Line 12: For example: Line 13: select fnSplitterMap('123=VM,456=Storage'); worth putting here also the result of this function Line 14: Line 15: Change-Id: I802ef2e0d90ff1c23646d7e1edbe3aa0bff62d2f -- To view, visit http://gerrit.ovirt.org/14913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I802ef2e0d90ff1c23646d7e1edbe3aa0bff62d2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches