ofri masad has posted comments on this change.

Change subject: engine: rename quota limit labels
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 605:     @DefaultStringValue("CPU Threads")
Line 606:     String clusterPopupCpuThreadsPanelTitle();
Line 607: 
Line 608:     @DefaultStringValue("Allow guests to use host threads as virtual 
CPU cores, utilizing AMD Clustered MultiThreading or Intel"
Line 609:             +
why did you move the +?
Line 610:             " Hyper-Threading technology on the virtualization host. 
Enabling this option may be useful for less" +
Line 611:             " CPU-intensive workloads, or to run guests with CPU 
configurations that would otherwise be restricted.")
Line 612:     String clusterPopupCpuThreadsInfo();
Line 613: 


--
To view, visit http://gerrit.ovirt.org/14168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I889f019b18b23c3b666d4d8e14a614103123fc30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to