ofri masad has posted comments on this change.
Change subject: wedadmin: Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
Line 91: .minLabel {
Line 92: height: 10px;
Line 93: width: 10px;
Line 94: margin-top: 3px;
Line 95: margin-left: 6px;
please use tabs for white spaces
Line 96: background-color: #AFBF27;
Line 97: }
Line 98: .maxLabel {
Line 99: height: 10px;
Line 199: <t:DialogTab
ui:field="clusterPolicyTab">
Line 200: <t:content>
Line 201: <g:FlowPanel>
Line 202:
<g:FlowPanel addStyleNames="{style.radioButtonsTabContent}">
Line 203: <g:Label
ui:field="schedulePolicyPanelTitle" addStyleNames="{style.panelTitle}" />
tabs
Line 204:
<g:HorizontalPanel addStyleNames="{style.marginPanel}">
Line 205:
<g:RadioButton ui:field="policyRadioButton_none"/>
Line 206:
<g:RadioButton ui:field="policyRadioButton_evenDist"/>
Line 207:
<g:RadioButton ui:field="policyRadioButton_powerSave"/>
Line 235:
</g:FlowPanel>
Line 236: <g:FlowPanel
ui:field="additionPropsPanel" addStyleNames="{style.nestedSubsequentPanel}">
Line 237: <g:Label
ui:field="additionPropsPanelTitle" addStyleNames="{style.panelTitle}" />
Line 238: <e:EntityModelCheckBoxEditor
ui:field="enableTrustedServiceEditor" />
Line 239: </g:FlowPanel>
tabs
Line 240: </g:FlowPanel>
Line 241: </t:content>
Line 242: </t:DialogTab>
Line 243: </t:tab>
--
To view, visit http://gerrit.ovirt.org/14611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59396a68708797b868bcd871abb08b3dd514f757
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
