ofri masad has posted comments on this change. Change subject: enigne:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestationService.java Line 11: import org.apache.commons.httpclient.protocol.ProtocolSocketFactory; Line 12: import org.codehaus.jackson.JsonFactory; Line 13: import org.codehaus.jackson.JsonParseException; Line 14: import org.codehaus.jackson.JsonParser; Line 15: import org.codehaus.jackson.JsonToken; import org.ovirt.engine.core.common.attestation.AttestationValue; Line 16: import org.ovirt.engine.core.common.businessentities.AttestationResultEnum; Line 17: import org.ovirt.engine.core.common.businessentities.VDS; Line 18: import org.ovirt.engine.core.common.config.Config; Line 19: import org.ovirt.engine.core.common.config.ConfigValues; .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java Line 36: if (vdss == null || vdss.size() == 0){ Line 37: break; Line 38: } Line 39: for (VDS vds: vdss){ Line 40: curVdsNames.add(vds.gethost_name()); method gethost_name() no longer exist - changed to getHostName() Line 41: } Line 42: } Line 43: if (curVdsNames.size()> attestationFirstStageSize) { Line 44: curVdsNames1 = curVdsNames.subList(0,attestationFirstStageSize-1); -- To view, visit http://gerrit.ovirt.org/14605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dave Chen <wei.d.c...@intel.com> Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com> Gerrit-Reviewer: Gang Wei <gang....@intel.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches