Vered Volansky has uploaded a new change for review.
Change subject: core: Removed unused Disk and LunDisk c'tors
......................................................................
core: Removed unused Disk and LunDisk c'tors
Non-default Disk c'tor is only used by LunDisk non-defualt c'tor, which
is not used at all.
Hence both are now removed.
Change-Id: Ie1740ea1f198b75ef4cceed2ecd3fb8dc53c44c2
Signed-off-by: Vered Volansky <vvola...@redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java
2 files changed, 0 insertions(+), 54 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/14858/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
index 85cdecd..da4354f 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
@@ -3,7 +3,6 @@
import java.util.ArrayList;
import org.ovirt.engine.core.common.utils.ObjectUtils;
-import org.ovirt.engine.core.compat.Guid;
/**
* The disk is contains data from the {@link BaseDisk} and the storage
specific details for the disk, which are
@@ -27,30 +26,6 @@
private Boolean plugged;
public Disk() {
- }
-
- public Disk(Guid id,
- DiskInterface diskInterface,
- boolean wipeAfterDelete,
- PropagateErrors propagateErrors,
- VmEntityType vmEntityType,
- int numberOfVms,
- ArrayList<String> vmNames,
- String diskAlias,
- String diskDescription,
- boolean shareable,
- boolean boot) {
- super(id,
- diskInterface,
- wipeAfterDelete,
- propagateErrors,
- diskAlias,
- diskDescription,
- shareable,
- boot);
- this.vmEntityType = vmEntityType;
- this.numberOfVms = numberOfVms;
- this.vmNames = vmNames;
}
/**
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java
index 50a0499..3ab5a8e 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java
@@ -1,9 +1,6 @@
package org.ovirt.engine.core.common.businessentities;
-import java.util.ArrayList;
-
import org.ovirt.engine.core.common.utils.ObjectUtils;
-import org.ovirt.engine.core.compat.Guid;
/**
* A type of disk that is stored directly on a LUN ({@link LUNs}). This disk
will contain the LUN details.
@@ -18,32 +15,6 @@
private LUNs lun;
public LunDisk() {
- }
-
- public LunDisk(Guid id,
- DiskInterface diskInterface,
- boolean wipeAfterDelete,
- PropagateErrors propagateErrors,
- VmEntityType vmEntityType,
- int numberOfVms,
- ArrayList<String> vmNames,
- String diskAlias,
- String diskDescription,
- boolean shareable,
- boolean boot,
- LUNs lun) {
- super(id,
- diskInterface,
- wipeAfterDelete,
- propagateErrors,
- vmEntityType,
- numberOfVms,
- vmNames,
- diskAlias,
- diskDescription,
- shareable,
- boot);
- this.lun = lun;
}
@Override
--
To view, visit http://gerrit.ovirt.org/14858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1740ea1f198b75ef4cceed2ecd3fb8dc53c44c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
