Lior Vernia has posted comments on this change.
Change subject: add and use GetProvidersByType
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetAllProvidersQuery.java
Line 1: package org.ovirt.engine.core.bll.provider;
Line 2:
Line 3: import org.ovirt.engine.core.bll.QueriesCommandBase;
Line 4: import org.ovirt.engine.core.common.businessentities.ProviderType;
Line 5: import org.ovirt.engine.core.common.queries.GetAllProvidersParameters;
I think this class might be missing from the commit.
Line 6:
Line 7: public class GetAllProvidersQuery<P extends GetAllProvidersParameters>
extends QueriesCommandBase<P> {
Line 8:
Line 9: public GetAllProvidersQuery(P parameters) {
....................................................
File
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
Line 162: JobExecutionStatus___FAILED=Failed
Line 163: JobExecutionStatus___ABORTED=Aborted
Line 164: JobExecutionStatus___UNKNOWN=Unknown
Line 165: ProviderType___FOREMAN=Foreman
Line 166: ProviderType___OPENSTACK_NETWORK=Openstack Network
Thanks for saving me the trouble of adding this :) Maybe just capitalize the S
("OpenStack") to be consistent with OpenStack branding?
--
To view, visit http://gerrit.ovirt.org/14774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87ef591a2470726cebef142e72eaee28103c81fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
