Alon Bar-Lev has posted comments on this change. Change subject: db: drop the obfuscation of database password ......................................................................
Patch Set 1: (1 inline comment) .................................................... File src/__main__.py Line 1441: "", Line 1442: "--pg-pass", Line 1443: dest="pg_pass", Line 1444: help=SUPPRESS_HELP, Line 1445: default=pg_pass Oh! I did not know there is such option... what will be suppressed, the entire help or the default? Line 1446: ) Line 1447: Line 1448: db_group.add_option( Line 1449: "", "--pg-dbname", dest="pg_dbname", -- To view, visit http://gerrit.ovirt.org/14741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches