Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: uicommon cleanup
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comments but in general this patch looks good.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
Line 93: @Override
Line 94: protected void syncSearch()
Line 95: {
Line 96: super.syncSearch();
Line 97: Task.Create(this, null).InvokeUIThread();
I see that "Task.Create(ITaskTarget,Object)" method is used also in some other
places, but all Task.Run() does is delegate back to
"ITaskTarget.run(TaskContext)" method.
In this case, as Daniel suggested, I'd remove "implements ITaskTarget" for
SearchSuggestModel, replace "Task.Create(this,null).InvokeUIThread()" with
"SearchSuggestModel.run(TaskContext)" method body, and remove
"SearchSuggestModel.run(TaskContext)" method afterwards.
In case of other classes using Task.Create(), i.e. DataCenterGuideModel +
StorageListModel, we could remove "implements ITaskTarget" but keep the "run()"
method, replacing TaskContext argument (containing "state") with "state" as
List<Object> directly. Also, we could remove "TaskContext context" field from
both model classes, not sure if we really need them altogether.
Line 98: }
Line 99:
Line 100: public void UpdateOptionsAsync(String search)
Line 101: {
--
To view, visit http://gerrit.ovirt.org/14654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica13e40edf51b91cec88405ae275b08c70edef44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
