Shubhendu Tripathi has uploaded a new change for review. Change subject: gluster: Corrected the event log to show old value ......................................................................
gluster: Corrected the event log to show old value Corrected the event log mechanism to show the old value also during the editing of volume from UI. Earlier the message used to show only new value being set for an option in the form "Volume Option <option-name>=<option-value> set on <volume-1>." Change-Id: I3cc679a70215d1f591cccf12554c3b1e076f49e8 Bug-Url: https://bugzilla.redhat.com/916117 Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/14730/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java index f8e220a..63d14d1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java @@ -66,6 +66,8 @@ // update the option value if it exists, else add it GlusterVolumeOptionEntity existingOption = getGlusterVolume().getOption(option.getKey()); if (existingOption != null) { + // Set the custom value for old value of the option before changing the same + addCustomValue(GlusterConstants.OPTION_OLD_VALUE, existingOption.getValue()); getGlusterOptionDao().updateVolumeOption(existingOption.getId(), option.getValue()); } else { getGlusterOptionDao().save(option); diff --git a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties index 6d1fb7a..1e8c460 100644 --- a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties +++ b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties @@ -550,7 +550,7 @@ # Gluster Messages GLUSTER_VOLUME_CREATE=Gluster Volume ${glusterVolumeName} created. GLUSTER_VOLUME_CREATE_FAILED=Creation of Gluster Volume ${glusterVolumeName} failed. -GLUSTER_VOLUME_OPTION_SET=Volume Option ${Key}=${Value} set on ${glusterVolumeName}. +GLUSTER_VOLUME_OPTION_SET=Volume Option ${Key}=${Value} set on ${glusterVolumeName}. Old Value of the option ${Key}=${oldvalue}. GLUSTER_VOLUME_OPTION_SET_FAILED=Volume Option ${Key}=${Value} could not be set on ${glusterVolumeName}. GLUSTER_VOLUME_START=Gluster Volume ${glusterVolumeName} started. GLUSTER_VOLUME_START_FAILED=Could not start Gluster Volume ${glusterVolumeName}. -- To view, visit http://gerrit.ovirt.org/14730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3cc679a70215d1f591cccf12554c3b1e076f49e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
