Allon Mureinik has submitted this change and it was merged.

Change subject: core: Removed unused Roles queries
......................................................................


core: Removed unused Roles queries

This patch removes several queries for Roles which are not used anymore.

This patch includes:
1. Removing GetRolesByAdElementIdQuery,
   GerRolesByAdElementIdAndNullTagQuery
   and GetRolesForDelegationByUserQuery.
2. Removing the VdcQueryType constants corresponding to the
   aforementioned queries.
3. Removing the GetRolesByAdElement constant from VdcQueryType, as it
   has no corresponding query class.
4. Removing RoleDAO.getAllForAdElement(Guid) and
   RoleDAO.getForAdElement(Guid) which were only used by the
   aforementioned queries. This removal includes the interfaces,
   implementations, underlying stored procedures  and tests.

Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M backend/manager/dbscripts/multi_level_administration_sp.sql
D 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdAndNullTagQuery.java
D 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdQuery.java
D 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesForDelegationByUserQuery.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAO.java
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java
M 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java
8 files changed, 0 insertions(+), 197 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to